Skip to content

DEV: fix Lua API right-side nav #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2024
Merged

DEV: fix Lua API right-side nav #726

merged 2 commits into from
Oct 3, 2024

Conversation

@dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented Oct 3, 2024 •
edited by atlassian bot
Loading

DOC-4343

Nav was using <a.../a> anchors instead of {#...}, causing the right-side nav to bug out.

@dwdougherty dwdougherty added bug Something isn't working dev labels Oct 3, 2024
@dwdougherty dwdougherty requested a review from a team October 3, 2024 19:33
@dwdougherty dwdougherty self-assigned this Oct 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Staging links:
https://redis.io/docs/staging/DOC-4343/develop/interact/programmability/lua-api

@mich-elle-luna
Copy link
Collaborator

mich-elle-luna commented Oct 3, 2024

thank you! for some reason (maybe the relref in a heading?) the ### Using [SELECT]({{< relref "/commands/select" >}}) inside scripts is still wonky if you can fix that one as well?

mich-elle-luna
mich-elle-luna requested changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@mich-elle-luna mich-elle-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using [SELECT]({{< relref "/commands/select" >}}) inside scripts is still weird

@dwdougherty
Copy link
Collaborator Author

dwdougherty commented Oct 3, 2024

Thanks, @mich-elle-luna ! I didn't catch that. Should be fixed now.

mich-elle-luna
mich-elle-luna approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@mich-elle-luna mich-elle-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dwdougherty dwdougherty merged commit 812723f into main Oct 3, 2024
4 checks passed
@dwdougherty dwdougherty deleted the DOC-4343 branch October 3, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mich-elle-luna mich-elle-luna mich-elle-luna approved these changes

Assignees

@dwdougherty dwdougherty

Labels

bug Something isn't working dev

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dwdougherty @mich-elle-luna